Fix mutateInstance for SearchTemplateRequestTests #43509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>test
|
Pinging @elastic/es-search |
|
@jtibshirani Requested your review as you were the last person to work on this. Thanks in advance! |
|
@baz Thanks for the review! @jtibshirani Sorry to ping you on this - just realized that you're on vacation, so I found a different reviewer. |
mayya-sharipova
pushed a commit
that referenced
this pull request
Jul 4, 2019
A seed was hit in (#43157) that caused mutateInstance to generate an identical instance. This change prevents that.
|
backported to 6.8 as well as there were failures of this test there. |
jtibshirani
pushed a commit
that referenced
this pull request
Feb 8, 2021
A seed was hit in (#43157) that caused mutateInstance to generate an identical instance. This change prevents that.
jtibshirani
pushed a commit
that referenced
this pull request
Feb 8, 2021
A seed was hit in (#43157) that caused mutateInstance to generate an identical instance. This change prevents that.
jtibshirani
pushed a commit
that referenced
this pull request
Feb 8, 2021
A seed was hit in (#43157) that caused mutateInstance to generate an identical instance. This change prevents that.
|
Also backported to 7.x. In general we can pre-emptively backport these fixes to all branches that are actively tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A seed was hit in (#43157) that caused mutateInstance to generate an identical instance. This change prevents that.