[ML][Data Frame] Add deduced mappings to _preview response payload #43742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core |
hendrikmuhs
reviewed
Jul 1, 2019
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeInt(docs.size()); | ||
| for (Map<String, Object> doc : docs) { | ||
| out.writeMapWithConsistentOrder(doc); | ||
| } | ||
| if (out.getVersion().onOrAfter(Version.V_7_3_0)) { | ||
| out.writeMap(mappings); |
There was a problem hiding this comment.
it seems mappings can be null, so would it make sense to use optional?
There was a problem hiding this comment.
@hendrikmuhs writeMap and readMap when it is just a Map<String,Object> handles null values internally.
There are also no BWC tests yet...still waiting on PR: #43506
There was a problem hiding this comment.
ok checked it, implicit magic, well...
hendrikmuhs
approved these changes
Jul 1, 2019
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeInt(docs.size()); | ||
| for (Map<String, Object> doc : docs) { | ||
| out.writeMapWithConsistentOrder(doc); | ||
| } | ||
| if (out.getVersion().onOrAfter(Version.V_7_3_0)) { | ||
| out.writeMap(mappings); |
There was a problem hiding this comment.
ok checked it, implicit magic, well...
|
run elasticsearch-ci/1 |
|
@elasticmachine update branch |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jul 2, 2019
…lastic#43742) * [ML][Data Frame] Add deduced mappings to _preview response payload * updating preview docs
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
_previewresponse payload to include the deduced mappings. The "mapping" format returned fromPivot#deduceMappingshas a non-standard format of{"field1": "field1Type", "field2.subfield": "field2.subfieldType"}. So, I opted to transform it so that it is in an appropriate format ofRelated to: elastic/kibana#39250