Forbid empty doc values on vector functions #43944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when a document misses a vector value, vector function returns 0 as a score for this document. We think this is incorrect behaviour. With this change, an error will be thrown if vector functions are used with docs that are missing vector doc values. Also VectorScriptDocValues is modified to allow size() function, which can be used to check if a document has a value for the vector field.
mayya-sharipova
added
the
:Search Relevance/Ranking
|
Pinging @elastic/es-search |
|
@jpountz I wanted to ask if you are fine if we expose Before we made a decision not to leak the internal representations of vectors. |
jpountz
approved these changes
Jul 5, 2019
jtibshirani
approved these changes
Jul 5, 2019
jtibshirani
reviewed
Jul 5, 2019
| @@ -46,7 +46,11 @@ public BytesRef get(int index) { | |||
|
|
|||
| @Override | |||
| public int size() { | |||
| throw new UnsupportedOperationException("vector fields may only be used via vector functions in scripts"); | |||
There was a problem hiding this comment.
Small comment: now that you can call size on a vector field, perhaps we could update the error message above to say "accessing a vector field's value through 'get' or 'value' is not supported".
mayya-sharipova
added a commit
that referenced
this pull request
Jul 5, 2019
Currently when a document misses a vector value, vector function returns 0 as a score for this document. We think this is incorrect behaviour. With this change, an error will be thrown if vector functions are used with docs that are missing vector doc values. Also VectorScriptDocValues is modified to allow size() function, which can be used to check if a document has a value for the vector field.
mayya-sharipova
added a commit
that referenced
this pull request
Jul 5, 2019
jtibshirani
added
:Search Relevance/Vectors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when a document misses a vector value, vector function
returns 0 as a score for this document. We think this is incorrect
and unexpected behaviour.
With this change, an error will be thrown if vector functions are
used with docs that are missing vector doc values.
Also VectorScriptDocValues is modified to allow size() function,
which can be used to check if a document has a value for the
vector field.