[ML-DataFrame] make checkpointing more robust #44344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- do not let checkpointing fail if indexes got deleted - treat missing seqNoStats as just created indices (checkpoint 0) - loglevel: do not treat failed updated checks as error fixes elastic#43992
|
Pinging @elastic/ml-core |
benwtrent
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
👍 We no longer throw NotFound exceptions on missing indices
👍 We handle indices going away between old checkpoints and new checkpoints
👍 We only expand to open indices
It may be good to log+audit when we detect an index was removed. It should just be an info as it may be a desired action, but it would be good to give indication that we are no longer seeing a previously checkpointed index.
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Jul 16, 2019
make checkpointing more robust: - do not let checkpointing fail if indexes got deleted - treat missing seqNoStats as just created indices (checkpoint 0) - loglevel: do not treat failed updated checks as error fixes elastic#43992
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Jul 16, 2019
make checkpointing more robust: - do not let checkpointing fail if indexes got deleted - treat missing seqNoStats as just created indices (checkpoint 0) - loglevel: do not treat failed updated checks as error fixes elastic#43992
This was referenced Jul 16, 2019
hendrikmuhs
pushed a commit
that referenced
this pull request
Jul 16, 2019
hendrikmuhs
pushed a commit
that referenced
this pull request
Jul 16, 2019
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jul 19, 2019
Since elastic#44344 we use IndicesOptions.LENIENT_EXPAND_OPEN when deciding which indices to include in checkpoint calculation. This change uses the same option when deciding which indices to search for data and which indices to get mappings from, otherwise there is a potential mismatch between the checkpoint details and what is searched elsewhere.
droberts195
added a commit
that referenced
this pull request
Jul 22, 2019
Since #44344 we use IndicesOptions.LENIENT_EXPAND_OPEN when deciding which indices to include in checkpoint calculation. This change uses the same option when deciding which indices to search for data and which indices to get mappings from, otherwise there is a potential mismatch between the checkpoint details and what is searched elsewhere.
droberts195
added a commit
that referenced
this pull request
Jul 22, 2019
Since #44344 we use IndicesOptions.LENIENT_EXPAND_OPEN when deciding which indices to include in checkpoint calculation. This change uses the same option when deciding which indices to search for data and which indices to get mappings from, otherwise there is a potential mismatch between the checkpoint details and what is searched elsewhere.
droberts195
added a commit
that referenced
this pull request
Jul 22, 2019
Since #44344 we use IndicesOptions.LENIENT_EXPAND_OPEN when deciding which indices to include in checkpoint calculation. This change uses the same option when deciding which indices to search for data and which indices to get mappings from, otherwise there is a potential mismatch between the checkpoint details and what is searched elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkpointing more robust:
fixes #43992
flagged as
non-issuebecause this belongs to a new unreleased feature, however, we see this as showstopper for releasing continuous data frames