SQL: use hasValue() methods from Elasticsearch's InspectionHelper classes #44745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the aggregations should return null (in case there is no value) or the value itself.
…o agg_hasValue_update
|
Pinging @elastic/es-search |
astefan
added a commit
that referenced
this pull request
Jul 24, 2019
Use InspectionHelper classes to decide if the aggregations should return null (in case there is no value) or the value itself. (cherry picked from commit dafd7b0)
This was referenced Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #35745.
Until #36020 was merged, we were deciding based on the internals of various aggregation classes if a certain aggregation worked on some documents and came up with an aggregated value or there were no documents to act on. This is relevant to SQL in order to return
nullor that specific value.This PR updates ES SQL's usage of the aggregation classes by using their own logic to decide if it should return
nullor not.