Allow empty token endpoint for implicit flow #45038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the implicit flow in OpenID Connect, the op.token_endpoint_url should not be mandatory as there is no need to contact the token endpoint of the OP.
jkakavas
added
>bug
:Security/Authentication
|
Pinging @elastic/es-security |
4 tasks
tvernum
reviewed
Aug 6, 2019
| String tokenEndpointString = config.getSetting(OP_TOKEN_ENDPOINT); | ||
| if (responseType.equals("code") && tokenEndpointString.isEmpty()) { | ||
| throw new SettingsException("The configuration setting [" + OP_TOKEN_ENDPOINT.getConcreteSettingForNamespace(name()).getKey() | ||
| + "] is required when [" + RP_RESPONSE_TYPE.getConcreteSettingForNamespace(name()).getKey() + " is set to \"code\""); |
There was a problem hiding this comment.
Suggested change
| + "] is required when [" + RP_RESPONSE_TYPE.getConcreteSettingForNamespace(name()).getKey() + " is set to \"code\""); | |
| + "] is required when [" + RP_RESPONSE_TYPE.getConcreteSettingForNamespace(name()).getKey() + "] is set to \"code\""); |
| URI tokenEndpoint; | ||
| try { | ||
| tokenEndpoint = new URI(require(config, OP_TOKEN_ENDPOINT)); | ||
| tokenEndpoint = new URI(tokenEndpointString); |
There was a problem hiding this comment.
I think it makes more sense for tokenEndpoint to be null (rather than an empty URI) if tokenEndpointString is empty.
|
@elasticmachine test this please |
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/1 |
jkakavas
added a commit
that referenced
this pull request
Aug 8, 2019
When using the implicit flow in OpenID Connect, the op.token_endpoint_url should not be mandatory as there is no need to contact the token endpoint of the OP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the implicit flow in OpenID Connect, the
op.token_endpoint_url should not be mandatory as there is no need
to contact the token endpoint of the OP.