Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vector functions to the Sort Script Context #45244

Conversation

mayya-sharipova
Copy link
Contributor

Closes #45243

@mayya-sharipova mayya-sharipova added the :Search Relevance/Ranking Scoring, rescoring, rank evaluation. label Aug 6, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@mayya-sharipova
Copy link
Contributor Author

@jimczi What do you think about the recent comment from the user? Do you think we should still proceed with this PR?

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really needed for primary sort since a script_query sorted by relevancy would achieve the same but I guess it's the only way to use these functions as a secondary sort.
LGTM

@mayya-sharipova
Copy link
Contributor Author

@jimczi Thanks for the feedback. We may need to close this PR. We have redesigned vector functions to expect ScoreScript parameter

cosineSimilarity(org.elasticsearch.script.ScoreScript, List, ... and it would be challenging to redesign them to expect NumberSortScript parameter as well

@jtibshirani jtibshirani added :Search Relevance/Vectors Vector search and removed :Search Relevance/Ranking Scoring, rescoring, rank evaluation. labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vector functions to Sort Script Context
6 participants