Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] APM mapping update #46244

Merged
merged 7 commits into from
Sep 25, 2019
Merged

Conversation

cachedout
Copy link
Contributor

@cachedout cachedout commented Sep 2, 2019

This creates needed mappings for additional APM metrics which were introduced by elastic/apm-server#2142

@cachedout cachedout changed the title Apm mapping update [Monitoring] APM mapping update Sep 2, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@ycombinator
Copy link
Contributor

I assume these mappings are needed for elastic/kibana#43998? If so, I'd suggest only mapping the fields we need to index for the new UI queries/aggs introduced in that PR to work correctly.

Reading through elastic/kibana#43998 that looks like beats_stats.metrics.apm-server.acm.* are the new fields being introduced. So I think we should only map those for now. I don't think we need to map beats_stats.metrics.apm-server.root.* or beats_stats.metrics.apm-server.sourcemap.* at this time; we can add mappings for those when we need to use those fields in queries/aggs from the Stack Monitoring UI.

@cachedout
Copy link
Contributor Author

Thanks, @ycombinator. I agree and have removed those two sections.

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. These seem to work fine alongside the Kibana changes

@cachedout cachedout merged commit 254655e into elastic:master Sep 25, 2019
@cachedout cachedout deleted the apm_mapping_update branch September 25, 2019 09:31
@cachedout cachedout removed the WIP label Sep 27, 2019
chrisronline pushed a commit to chrisronline/elasticsearch that referenced this pull request Jun 24, 2020
* Add acm mapping to APM for beats

* Add root mapping for APM

* Add sourcemap mapping to APM

* Fix missing properties

* Fix a second missing properties

* Add request property to acm

* Remove root and sourcemap per review
chrisronline added a commit that referenced this pull request Jun 24, 2020
* Add acm mapping to APM for beats

* Add root mapping for APM

* Add sourcemap mapping to APM

* Fix missing properties

* Fix a second missing properties

* Add request property to acm

* Remove root and sourcemap per review

Co-authored-by: Mike Place <mike.place@elastic.co>
chrisronline added a commit that referenced this pull request Jun 24, 2020
* Add acm mapping to APM for beats

* Add root mapping for APM

* Add sourcemap mapping to APM

* Fix missing properties

* Fix a second missing properties

* Add request property to acm

* Remove root and sourcemap per review

Co-authored-by: Mike Place <mike.place@elastic.co>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants