Change format of MulticlassConfusionMatrix result to be more self-explanatory #48174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
revamp_multiclass_confusion_matrix
branch
from
66e1005
to
071cbd7
Compare
przemekwitek
force-pushed
the
revamp_multiclass_confusion_matrix
branch
from
071cbd7
to
fa6ab5b
Compare
|
Pinging @elastic/ml-core (:ml) |
|
run elasticsearch-ci/packaging-sample-matrix |
przemekwitek
force-pushed
the
revamp_multiclass_confusion_matrix
branch
4 times, most recently
from
4ce3aa3
to
97628e2
Compare
|
@elasticmachine update branch |
1 similar comment
|
@elasticmachine update branch |
przemekwitek
force-pushed
the
revamp_multiclass_confusion_matrix
branch
2 times, most recently
from
2fd6087
to
dfecdf6
Compare
benwtrent
reviewed
Oct 18, 2019
| @Override | ||
| public XContentBuilder toXContent(XContentBuilder builder, Params params) throws IOException { | ||
| builder.startObject(); | ||
| builder.field(PREDICTED_CLASS.getPreferredName(), predictedClass); |
There was a problem hiding this comment.
According to the ctor, both of these are nullable.
...ticsearch/client/ml/dataframe/evaluation/classification/MulticlassConfusionMatrixMetric.java
Show resolved
Hide resolved
| String actualClass, long actualClassDocCount, List<PredictedClass> predictedClasses, long otherPredictedClassDocCount) { | ||
| this.actualClass = actualClass; | ||
| this.actualClassDocCount = actualClassDocCount; | ||
| this.predictedClasses = Collections.unmodifiableList(predictedClasses); |
There was a problem hiding this comment.
Should this be nullable? I think it would throw if predictedClasses == null
| this.otherClassesCount = otherClassesCount; | ||
| public Result(List<ActualClass> actualClasses, long otherActualClassCount) { | ||
| this.actualClasses = Collections.unmodifiableList(Objects.requireNonNull(actualClasses)); | ||
| this.otherActualClassCount = otherActualClassCount; |
There was a problem hiding this comment.
might be good to do a otherActualClassCount >= 0 check.
| in.readMap(StreamInput::readString, in2 -> in2.readMap(StreamInput::readString, StreamInput::readLong))); | ||
| this.otherClassesCount = in.readLong(); | ||
| this.actualClasses = Collections.unmodifiableList(in.readList(ActualClass::new)); | ||
| this.otherActualClassCount = in.readLong(); |
There was a problem hiding this comment.
Suggested change
| this.otherActualClassCount = in.readLong(); | |
| this.otherActualClassCount = in.readVLong(); |
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeString(actualClass); | ||
| out.writeLong(actualClassDocCount); |
There was a problem hiding this comment.
Suggested change
| out.writeLong(actualClassDocCount); | |
| out.writeVLong(actualClassDocCount); |
|
|
||
| public PredictedClass(StreamInput in) throws IOException { | ||
| this.predictedClass = in.readString(); | ||
| this.count = in.readLong(); |
There was a problem hiding this comment.
Suggested change
| this.count = in.readLong(); | |
| this.count = in.readVLong(); |
| @Override | ||
| public void writeTo(StreamOutput out) throws IOException { | ||
| out.writeString(predictedClass); | ||
| out.writeLong(count); |
There was a problem hiding this comment.
Suggested change
| out.writeLong(count); | |
| out.writeVLong(count); |
| private final long count; | ||
|
|
||
| public PredictedClass(String predictedClass, long count) { | ||
| this.predictedClass = predictedClass; |
|
|
||
| public PredictedClass(String predictedClass, long count) { | ||
| this.predictedClass = predictedClass; | ||
| this.count = count; |
przemekwitek
force-pushed
the
revamp_multiclass_confusion_matrix
branch
2 times, most recently
from
cc20654
to
9b1c359
Compare
|
run elasticsearch-ci/packaging-sample-matrix |
przemekwitek
force-pushed
the
revamp_multiclass_confusion_matrix
branch
from
9b1c359
to
92a6dd4
Compare
benwtrent
approved these changes
Oct 21, 2019
|
run elasticsearch-ci/packaging-sample-matrix |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Oct 21, 2019
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Oct 21, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current MulticlassConfusionMatrix result can be confusing to the API user.
They have no means to tell if the outer map is actual or predicted. Similarly for inner map.
This PR fixes that by making the format strict (naming each field).
Relates #46735