Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when MaxDirectMemorySize or Netty Allocator Type may be incorrect (Windows/JDK8 only issue) #48546

Closed
wants to merge 2 commits into from
Closed

Warn when MaxDirectMemorySize or Netty Allocator Type may be incorrect (Windows/JDK8 only issue) #48546

wants to merge 2 commits into from

Commits on Oct 25, 2019

  1. Warn when MaxDirectMemorySize may be incorrect (Windows/JDK8 only iss… 

    …ue) (elastic#48365)

Our JVM ergonomics extract max heap size from JDK PrintFlagsFinal output.
On JDK 8, there is a system-dependent bug where memory sizes are cast to
32-bit integers. On affected systems (namely, Windows), when 1/4 of physical
memory is more than the maximum integer value, the output of PrintFlagsFinal
will be inaccurate. In the pathological case, where the max heap size would
be a multiple of 4g, the test will fail.

The practical effect of this bug, beyond test failures, is that we may set
MaxDirectMemorySize to an incorrect value on Windows. This commit adds a
warning about this situation during startup.
    @williamrandolph
    williamrandolph committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    ddf820a View commit details
    Browse the repository at this point in the history

  2. Warn for io.netty property on 7.5 for Windows/jdk8

    @williamrandolph
    williamrandolph committed Oct 25, 2019
    Configuration menu
    Copy the full SHA
    90721b8 View commit details
    Browse the repository at this point in the history