Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport improvements around netty direct buffer pooling #48550

Merged
merged 3 commits into from
Oct 26, 2019
Merged

Backport improvements around netty direct buffer pooling #48550

merged 3 commits into from
Oct 26, 2019

Commits on Oct 26, 2019

  1. Remove option to enable direct buffer pooling (elastic#48310) 

    This commit removes the option to change the netty system properties to
reenable the direct buffer pooling. It also removes the need for us to
disable the buffer pooling in the system properties file. Instead, we
programmatically craete an allocator that is used by our networking
layer.

This commit does introduce an Elasticsearch property which allows the
user to fallback on the netty default allocator. If they choose this
option, they can configure the default allocator how they wish using the
standard netty properties.
    @Tim-Brooks
    Tim-Brooks committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    ad5e509 View commit details
    Browse the repository at this point in the history

  2. Remove default netty allocator empty assertions (elastic#48356) 

    This commit removes a problematic assertion that the netty default
allocator is not used. This assertion is problematic because any other
test can cause this task to fail by touching the default allocator. We
assert that we are using heap buffers in the channel.
    @Tim-Brooks
    Tim-Brooks committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    87b245b View commit details
    Browse the repository at this point in the history

  3. Upgrade to Netty 4.1.43 (elastic#48484) 

    With this update we can remove the mitigation in our custom allocator
which forces heap buffer allocations.
    @Tim-Brooks
    Tim-Brooks committed Oct 26, 2019
    Configuration menu
    Copy the full SHA
    1615cb5 View commit details
    Browse the repository at this point in the history