-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make each analysis report desired field mappings to be copied #50219
Merged
przemekwitek
merged 3 commits into
elastic:master
from
przemekwitek:copy_dep_var_mapping
Dec 20, 2019
Merged
Make each analysis report desired field mappings to be copied #50219
przemekwitek
merged 3 commits into
elastic:master
from
przemekwitek:copy_dep_var_mapping
Dec 20, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
copy_dep_var_mapping
branch
6 times, most recently
from
December 17, 2019 12:51
c2f2330
to
aacf4b2
Compare
Pinging @elastic/ml-core (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left a few points to go through.
...in/core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/Classification.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/DataFrameAnalysis.java
Outdated
Show resolved
Hide resolved
...core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/DataFrameAnalysis.java
Outdated
Show resolved
Hide resolved
.../core/src/main/java/org/elasticsearch/xpack/core/ml/dataframe/analyses/OutlierDetection.java
Outdated
Show resolved
Hide resolved
...-multi-node-tests/src/test/java/org/elasticsearch/xpack/ml/integration/ClassificationIT.java
Outdated
Show resolved
Hide resolved
...ck/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/DataFrameAnalyticsIndex.java
Outdated
Show resolved
Hide resolved
...ck/plugin/ml/src/main/java/org/elasticsearch/xpack/ml/dataframe/DataFrameAnalyticsIndex.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
copy_dep_var_mapping
branch
from
December 20, 2019 10:04
aacf4b2
to
7bae149
Compare
przemekwitek
force-pushed
the
copy_dep_var_mapping
branch
from
December 20, 2019 10:08
7bae149
to
c06d9ab
Compare
dimitris-athanasiou
approved these changes
Dec 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Dec 20, 2019
przemekwitek
added a commit
that referenced
this pull request
Dec 20, 2019
Merged
2 tasks
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides means for the analysis to request field mappings to be copied from source index to destination index.
Closes #50119