Deprecate _upgrade API (#47678)
#50484
Conversation
timoninmaxim
changed the title
timoninmaxim
force-pushed
the
fork/master
branch
from
984c704
to
8c83273
Compare
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
There was a problem hiding this comment.
Thanks for opening this @timoninmaxim, I left a couple of comments. I don't think we need to rename the classes here, just annotate them with @Deprecated
...r/src/main/java/org/elasticsearch/rest/action/admin/indices/RestUpgradeActionDeprecated.java
Show resolved
Hide resolved
...main/java/org/elasticsearch/rest/action/admin/indices/RestUpgradeStatusActionDeprecated.java
Show resolved
Hide resolved
|
@elasticmachine ok to test |
| @@ -47,6 +47,10 @@ | |||
| "default":"open", | |||
| "description":"Whether to expand wildcard expression to concrete indices that are open, closed or both." | |||
| } | |||
| }, | |||
| "deprecated":{ | |||
There was a problem hiding this comment.
It appears that this field causes all sorts of test failures. I believe only the "parts" sub-objects support deprecations in the REST spec for now, so this should be removed and "DEPRECATED" added to the description
There was a problem hiding this comment.
This is my fault, I used wrong gradle check command and missed this tests. So, I've fixed it and some other tests in new commit.
There was a problem hiding this comment.
I used this doc for deprecation: https://github.com/elastic/elasticsearch/tree/master/rest-api-spec#deprecations. Currenlty it incorrectly shows how to deprecate entire API. Is it a inaccuracy in the documentation or bug in a code?
There was a problem hiding this comment.
hi @dakrone ! Could you please check my last comment above? Should we do smth with that the doc is incorrect?
| @@ -55,6 +55,10 @@ | |||
| "type":"boolean", | |||
| "description":"If true, only ancient (an older Lucene major release) segments will be upgraded" | |||
| } | |||
| }, | |||
| "deprecated":{ | |||
There was a problem hiding this comment.
Same comment about deprecation here
timoninmaxim
force-pushed
the
fork/master
branch
from
defdf38
to
76bd135
Compare
|
Thanks for iterating on this @timoninmaxim! |
* Deprecates _upgrade API Ref elastic#47678 * Move deprecation flags to path section. Add deprecation warning tests for _upgrade API. Ref elastic#47678
danhermann
added
:Data Management/Indices APIs
* Deprecates _upgrade API Ref elastic#47678 * Move deprecation flags to path section. Add deprecation warning tests for _upgrade API. Ref elastic#47678
pugnascotia
changed the title
_upgrade API (#47678)
Issue comment #47678
Suggest deprecate Upgrade API instead of implementing high-level API for it.