Move EC2 Discovery Tests to Mock Rest API #50605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move EC2 discovery tests to using the mock REST API introduced in elastic#50550 instead of mocking the AWS SDK classes manually. Move the trivial remaining AWS SDK mocks to the single test suit that was using them.
original-brownbear
added
>test
|
Pinging @elastic/es-distributed (:Distributed/Discovery-Plugins) |
|
Thanks @original-brownbear, sorry for missing this when it was opened. Looks good; would you merge master just in case something's changed in the past month-and-a-bit? |
|
@DaveCTurner thanks for taking a look :) Merged in |
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 12, 2020
Move EC2 discovery tests to using the mock REST API introduced in elastic#50550 instead of mocking the AWS SDK classes manually. Move the trivial remaining AWS SDK mocks to the single test suit that was using them.
original-brownbear
added a commit
that referenced
this pull request
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving these tests like we did for S3 away from mocks:
Move EC2 discovery tests to using the mock REST API introduced in
#50550 instead of mocking
the AWS SDK classes manually.
Move the trivial remaining AWS SDK mocks to the single test suit that
was using them.