Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Use s parameter in cat API overview example #50616

Merged
merged 3 commits into from
Jan 14, 2020
Merged

[DOCS] Use s parameter in cat API overview example #50616

merged 3 commits into from
Jan 14, 2020

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jan 3, 2020

Updates a snippet to use the s query string parameter rather than piping the output to a separate sort command.

This ensures the snippet is tested and available in clients other than curl (Kibana console, etc.).

Issue was originally raised by @hackaholic in #40926.

@jrodewig jrodewig added >docs General docs changes :Data Management/CAT APIs Text APIs behind /_cat labels Jan 3, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/CAT APIs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Updates a snippet to use the `s` query string parameter rather than
piping the output to a separate `sort` command.

This ensures the snippet is tested and available in clients other than
curl (Kibana console, etc.).

Issue was originally raised by @hackaholic in #40926.
@jrodewig jrodewig added the WIP label Jan 3, 2020
@jrodewig jrodewig removed the WIP label Jan 3, 2020
@jrodewig jrodewig changed the title [DOCS] Use s QSP in cat API overview example [DOCS] Use s parameter in cat API overview example Jan 3, 2020
@jrodewig jrodewig requested a review from javanna January 6, 2020 18:04
@martijnvg martijnvg requested review from martijnvg and removed request for javanna January 9, 2020 15:31
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrodewig
Copy link
Contributor Author

Thanks @martijnvg!

@jrodewig jrodewig merged commit 9c192ca into elastic:master Jan 14, 2020
@jrodewig jrodewig deleted the cat-sort-instead-of-pipe branch January 14, 2020 13:21
jrodewig added a commit that referenced this pull request Jan 14, 2020
Updates a snippet to use the `s` query string parameter rather than
piping the output to a separate `sort` command.

This ensures the snippet is tested and available in clients other than
curl (Kibana console, etc.).

Issue was originally raised by @hackaholic in #40926.
jrodewig added a commit that referenced this pull request Jan 14, 2020
Updates a snippet to use the `s` query string parameter rather than
piping the output to a separate `sort` command.

This ensures the snippet is tested and available in clients other than
curl (Kibana console, etc.).

Issue was originally raised by @hackaholic in #40926.
@jrodewig
Copy link
Contributor Author

Backport commits

master: 9c192ca
7.x: f028ab0
7.5: 1a96cb9

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Updates a snippet to use the `s` query string parameter rather than
piping the output to a separate `sort` command.

This ensures the snippet is tested and available in clients other than
curl (Kibana console, etc.).

Issue was originally raised by @hackaholic in elastic#40926.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants