Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE bug inner_hits #50709

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

mayya-sharipova
Copy link
Contributor

When there several subqueries on different relations of the join field,
and only one of subqueries is using inner_hits, NPE occurs.
This PR prevents NPE error.

Closes #50539

When there several subqueries on different relations of the join field,
and only one of subqueries is using inner_hits, NPE occurs.
This PR prevents NPE error.

Closes elastic#50539
@mayya-sharipova mayya-sharipova added the :Search/Search Search-related issues that do not fall into other categories label Jan 7, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @mayya-sharipova

@mayya-sharipova mayya-sharipova merged commit 0131ec4 into elastic:master Jan 7, 2020
@mayya-sharipova mayya-sharipova deleted the inner-hits-error branch January 7, 2020 17:20
mayya-sharipova added a commit that referenced this pull request Jan 7, 2020
When there several subqueries on different relations of the join field,
and only one of subqueries is using inner_hits, NPE occurs.
This PR prevents NPE error.

Closes #50539
mayya-sharipova added a commit that referenced this pull request Jan 7, 2020
When there several subqueries on different relations of the join field,
and only one of subqueries is using inner_hits, NPE occurs.
This PR prevents NPE error.

Closes #50539
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
When there several subqueries on different relations of the join field,
and only one of subqueries is using inner_hits, NPE occurs.
This PR prevents NPE error.

Closes elastic#50539
mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Jul 20, 2021
This patch fixes test skip version, which was incorrect before.
It also removes a duplicate index creation, as the index is already created
during setup stage.

Related to elastic#50709
mayya-sharipova added a commit that referenced this pull request Jul 20, 2021
This patch fixes test skip version, which was incorrect before.
It also removes a duplicate index creation, as the index is already created
during setup stage.

Related to #50709
mayya-sharipova added a commit that referenced this pull request Jul 20, 2021
This patch fixes test skip version, which was incorrect before.
It also removes a duplicate index creation, as the index is already created
during setup stage.

Related to #50709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v6.8.7 v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when having two "should" sub-queries with one has_parent w/ inner_hits
4 participants