Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GlobalBuildInfo support packed-refs with work-tree #50791

Conversation

henningandersen
Copy link
Contributor

The packed-refs support was using the original .git path, changed to use
the real .git directory after reference from worktree has been followed.

Relates #47464

The packed-refs support was using the original .git path, changed to use
the real .git directory after reference from worktree has been followed.

Relates elastic#47464
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Build)

Copy link
Contributor

@williamrandolph williamrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reproduced the worktree problem, verified the fix locally, and checked that nothing broke under the main repo. Everything looks good!

@henningandersen henningandersen merged commit 616b905 into elastic:master Jan 10, 2020
henningandersen added a commit that referenced this pull request Jan 10, 2020
The packed-refs support was using the original .git path, changed to use
the real .git directory after reference from worktree has been followed.

Relates #47464
henningandersen added a commit that referenced this pull request Jan 10, 2020
The packed-refs support was using the original .git path, changed to use
the real .git directory after reference from worktree has been followed.

Relates #47464
@henningandersen
Copy link
Contributor Author

henningandersen commented Jan 10, 2020

Backport to 6.8 pending done

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
The packed-refs support was using the original .git path, changed to use
the real .git directory after reference from worktree has been followed.

Relates elastic#47464
henningandersen added a commit that referenced this pull request Jan 23, 2020
The packed-refs support was using the original .git path, changed to use
the real .git directory after reference from worktree has been followed.

Relates #47464
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jun 25, 2020
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Jun 25, 2020
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants