Skip test suite entirely for non-applicable distribution types #50824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Vieira <portugee@gmail.com>
mark-vieira
added
:Delivery/Packaging
|
Pinging @elastic/es-core-infra (:Core/Infra/Packaging) |
mark-vieira
added a commit
that referenced
this pull request
Jan 9, 2020
mark-vieira
added a commit
that referenced
this pull request
Jan 9, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are getting loads of Windows packaging test failures while attempting to do cleanup for a test suite that shouldn't even run at all on Windows. This is due to the incorrect usage of the junit
@Beforeinstead of@BeforeClassannotation. So instead of skipping the suite entirely, we are skipping all individual tests but still trying to do post-test cleanup, which is entirely unnecessary in this case. This PR simply changes the annotation on the test predicate assertion method.