-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Old Version Clusters From Corrupting Snapshot Repositories #50853
Merged
original-brownbear
merged 2 commits into
elastic:master
from
original-brownbear:write-version-information-to-repository-data
Jan 13, 2020
Merged
Prevent Old Version Clusters From Corrupting Snapshot Repositories #50853
original-brownbear
merged 2 commits into
elastic:master
from
original-brownbear:write-version-information-to-repository-data
Jan 13, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up to elastic#50692 that starts writing a `min_version` field to the `RepositoryData` so that pre-7.6 ES versions can not read it (and potentially corrupt it if they attempt to modify the repo contents) after the repository moved to the new metadata format.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.0.0
v7.6.0
labels
Jan 10, 2020
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
…rmation-to-repository-data
ywelsch
approved these changes
Jan 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks Yannick! |
original-brownbear
deleted the
write-version-information-to-repository-data
branch
January 13, 2020 12:32
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 13, 2020
…lastic#50853) Follow up to elastic#50692 that starts writing a `min_version` field to the `RepositoryData` so that pre-7.6 ES versions can not read it (and potentially corrupt it if they attempt to modify the repo contents) after the repository moved to the new metadata format.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 13, 2020
Add tracking of snapshot versions to `RepositoryData` to make BwC logic more efficient. Follow up to elastic#50853
original-brownbear
added a commit
that referenced
this pull request
Jan 14, 2020
Add tracking of snapshot versions to RepositoryData to make BwC logic more efficient. Follow up to #50853
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jan 14, 2020
Add tracking of snapshot versions to RepositoryData to make BwC logic more efficient. Follow up to elastic#50853
original-brownbear
added a commit
that referenced
this pull request
Jan 14, 2020
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…lastic#50853) Follow up to elastic#50692 that starts writing a `min_version` field to the `RepositoryData` so that pre-7.6 ES versions can not read it (and potentially corrupt it if they attempt to modify the repo contents) after the repository moved to the new metadata format.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Add tracking of snapshot versions to RepositoryData to make BwC logic more efficient. Follow up to elastic#50853
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>non-issue
v7.6.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #50692 that starts writing a
min_version
field tothe
RepositoryData
so that pre-7.6 ES versions can not read it(and potentially corrupt it if they attempt to modify the repo contents)
after the repository moved to the new metadata format.