Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Old Version Clusters From Corrupting Snapshot Repositories #50853

Conversation

original-brownbear
Copy link
Member

Follow up to #50692 that starts writing a min_version field to
the RepositoryData so that pre-7.6 ES versions can not read it
(and potentially corrupt it if they attempt to modify the repo contents)
after the repository moved to the new metadata format.

Follow up to elastic#50692 that starts writing a `min_version` field to
the `RepositoryData` so that pre-7.6 ES versions can not read it
(and potentially corrupt it if they attempt to modify the repo contents)
after the repository moved to the new metadata format.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear
Copy link
Member Author

@ywelsch @tlrx this should get us to a safe place for now once also backported to 7.6 then in a follow-up I'd look into making things more efficient by moving the Version information for snapshots into the index-N and also into tracking shard gens on a best effort basis for SLM 7.6.

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear
Copy link
Member Author

Thanks Yannick!

@original-brownbear original-brownbear merged commit c30e05e into elastic:master Jan 13, 2020
@original-brownbear original-brownbear deleted the write-version-information-to-repository-data branch January 13, 2020 12:32
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jan 13, 2020
…lastic#50853)

Follow up to elastic#50692 that starts writing a `min_version` field to
the `RepositoryData` so that pre-7.6 ES versions can not read it
(and potentially corrupt it if they attempt to modify the repo contents)
after the repository moved to the new metadata format.
original-brownbear added a commit that referenced this pull request Jan 13, 2020
…50853) (#50913)

Follow up to #50692 that starts writing a `min_version` field to
the `RepositoryData` so that pre-7.6 ES versions can not read it
(and potentially corrupt it if they attempt to modify the repo contents)
after the repository moved to the new metadata format.
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jan 13, 2020
Add tracking of snapshot versions to `RepositoryData` to make BwC logic more efficient.
Follow up to elastic#50853
original-brownbear added a commit that referenced this pull request Jan 14, 2020
Add tracking of snapshot versions to RepositoryData to make BwC logic more efficient.
Follow up to #50853
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Jan 14, 2020
Add tracking of snapshot versions to RepositoryData to make BwC logic more efficient.
Follow up to elastic#50853
original-brownbear added a commit that referenced this pull request Jan 14, 2020
* Track Snapshot Version in RepositoryData (#50930)

Add tracking of snapshot versions to RepositoryData to make BwC logic more efficient.
Follow up to #50853
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
…lastic#50853)

Follow up to elastic#50692 that starts writing a `min_version` field to
the `RepositoryData` so that pre-7.6 ES versions can not read it
(and potentially corrupt it if they attempt to modify the repo contents)
after the repository moved to the new metadata format.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Add tracking of snapshot versions to RepositoryData to make BwC logic more efficient.
Follow up to elastic#50853
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants