Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testSkipRefreshIfShardIsRefreshingAlready #50856

Merged
merged 2 commits into from
Jan 10, 2020
Merged

Fix testSkipRefreshIfShardIsRefreshingAlready #50856

merged 2 commits into from
Jan 10, 2020

Commits on Jan 10, 2020

  1. Fix testSkipRefreshIfShardIsRefreshingAlready 

    The test checked queue size and active count, however,
ThreadPoolExecutor pulls out the request from the queue before marking
the worker active, risking that we think all tasks are done when they
are not. Now check on completed-tasks metric instead, which is
guaranteed to be monotonic.

Relates elastic#50769
    @henningandersen
    henningandersen committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    66a6dee View commit details
    Browse the repository at this point in the history

  2. Removed print statement.

    @henningandersen
    henningandersen committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    1b8867e View commit details
    Browse the repository at this point in the history