-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated requirement of CCR #50859
Conversation
Pinging @elastic/es-distributed (:Distributed/CCR) |
Pinging @elastic/es-docs (>docs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -41,58 +41,3 @@ to a follower the following process will fail due to incomplete history on the l | |||
The default value is `12h`. | |||
|
|||
For more information about index settings, see {ref}/index-modules.html[Index modules]. | |||
|
|||
|
|||
[[ccr-overview-beats]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the Beats and APM docs link to this section. Can we add a redirect to redirects.asciidoc
so these links don't break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That note (elastic/beats#9427) can be removed from the docs, as it no longer applies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened elastic/beats#15506 to remove the note in the Beats/APM docs. The docs CI tests will continue to fail for this PR until that's merged or we add a redirect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dnhatn elastic/beats#15506 is now merged. If you update this branch, the docs CI test should pick up the changes in Beats and pass.
run elasticsearch-ci/docs |
@dnhatn Looks like my PR missed a link. Opened elastic/apm-server#3147 to remove. |
@elasticmachine run elasticsearch-ci/docs |
@jasontedor @jrodewig Thanks for reviewing. |
With retention leases, users do not need to set index.soft_deletes.retention.operations. This change removes it from the requirements of CCR
With retention leases, users do not need to set index.soft_deletes.retention.operations. This change removes it from the requirements of CCR
With retention leases, users do not need to set index.soft_deletes.retention.operations. This change removes it from the requirements of CCR
With retention leases, users do not need to set index.soft_deletes.retention.operations. This change removes it from the requirements of CCR
With retention leases, users do not need to set
index.soft_deletes.retention.operations
. This change removes it from the requirements of CCR.