Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix queuing in AsyncLucenePersistedState #50958

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Fix queuing in AsyncLucenePersistedState #50958

merged 3 commits into from
Jan 14, 2020

Conversation

ywelsch
Copy link
Contributor

@ywelsch ywelsch commented Jan 14, 2020

The logic in AsyncLucenePersistedState was flawed, unexpectedly queuing up two update tasks in parallel.

Marked as non-issue as it's non-released code.

@ywelsch ywelsch added >non-issue :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.0.0 v7.6.0 labels Jan 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Cluster Coordination)

DaveCTurner
DaveCTurner requested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also assert threadPoolExecutor.isShutdown() in onRejection()?

DaveCTurner
DaveCTurner approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ywelsch
Copy link
Contributor Author

ywelsch commented Jan 14, 2020

Could we also assert threadPoolExecutor.isShutdown() in onRejection()?

yes, I've also removed the try/catch block (it's not needed)

@ywelsch ywelsch merged commit b146740 into elastic:master Jan 14, 2020
ywelsch added a commit that referenced this pull request Jan 14, 2020
@ywelsch
Fix queuing in AsyncLucenePersistedState (#50958)
f1c5031 
The logic in AsyncLucenePersistedState was flawed, unexpectedly queuing up two update tasks
in parallel.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@ywelsch @SivagurunathanV
Fix queuing in AsyncLucenePersistedState (elastic#50958)
249d040 
The logic in AsyncLucenePersistedState was flawed, unexpectedly queuing up two update tasks
in parallel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

@original-brownbear original-brownbear Awaiting requested review from original-brownbear

Assignees
No one assigned
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >non-issue v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywelsch @elasticmachine @DaveCTurner @jakelandis