Don't use user-supplied type when building DocumentMapper #50960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (:Search/Mapping) |
romseygeek
added a commit
that referenced
this pull request
Jan 20, 2020
…0960)" (#51214) Reverts #50960 This commit has been causing test failures during upgrade tests: specifically, an upgraded node becomes master and sends a cluster state update to a 7.x node; this node sees that the mapping version of its .tasks index is the same as the master, so asserts that the serialized mappings are the same; however, because the master has rewritten the mapping to use _docinstead oftasks`, we get an assertion failure. The logical fix is for the master to increment its mapping version when it rewrites the mapping, but there isn't a simple way to do that currently. This reverts commit 774bfb5.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
) This commit begins the process of removing types from the document parsing infrastructure. Initially, we just ignore the user-supplied type after it has been removed from the mapping json structure, and always supply _doc as the name of the root parser. The production code change is very small here, and most of the changeset consists of alterations to Mapper test code that was passing in non-standard type names and checking serialization. Relates to elastic#41059
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…astic#50960)" (elastic#51214) Reverts elastic#50960 This commit has been causing test failures during upgrade tests: specifically, an upgraded node becomes master and sends a cluster state update to a 7.x node; this node sees that the mapping version of its .tasks index is the same as the master, so asserts that the serialized mappings are the same; however, because the master has rewritten the mapping to use _docinstead oftasks`, we get an assertion failure. The logical fix is for the master to increment its mapping version when it rewrites the mapping, but there isn't a simple way to do that currently. This reverts commit 774bfb5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit begins the process of removing types from the document parsing
infrastructure. Initially, we just ignore the user-supplied type after it has been
removed from the mapping json structure, and always supply
_docas the nameof the root parser.
The production code change is very small here, and most of the changeset
consists of alterations to Mapper test code that was passing in non-standard
type names and checking serialization.
Relates to #41059