[ML] Removed key value from the catch regex test #50977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimitris-athanasiou
added
:ml
|
Pinging @elastic/ml-core (:ml) |
dimitris-athanasiou
changed the title
delvedor
added a commit
to delvedor/elasticsearch
that referenced
this pull request
Jan 15, 2020
delvedor
added a commit
that referenced
this pull request
Jan 15, 2020
delvedor
added a commit
to elastic/elasticsearch-js
that referenced
this pull request
Jan 15, 2020
- With elastic/elasticsearch#50977 this skips are no longer valid
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
|
cc @elastic/es-clients |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks!
In some tests, where we are using a regex to catch an error, we are also checking the key value, but the test assumes that the body is serialized as yaml while other clients test it as json.
This pr removes the
reason=part fo the regex, as it's not important to verify the key value as well, because this message will be present only in that part of the json.