"did you mean" for ObjectParser with top named #51018
Conversation
When you declare an ObjectParser with top level named objects like we do with `significant_terms` we didn't support "did you mean". This fixes that. Relates elastic#50938
| } | ||
| if (false == entry.name.match(name, parser.getDeprecationHandler())) { | ||
| /* Note that this shouldn't happen because we already looked up the entry using the names but we need to call `match` anyway | ||
| * because it is responsible for logging deprecation warnings. */ | ||
| throw new NamedObjectNotFoundException(parser.getTokenLocation(), | ||
| throw new XContentParseException(parser.getTokenLocation(), |
There was a problem hiding this comment.
All of the exceptions that I changed to XContentParseException are really more development errors than usage errors.
There was a problem hiding this comment.
And they don't have the critical candidates set.
nik9000
added
:Core/Infra/Core
|
Pinging @elastic/es-core-infra (:Core/Infra/Core) |
I believe so. |
I think we'd more likely want to port the |
When you declare an ObjectParser with top level named objects like we do with `significant_terms` we didn't support "did you mean". This fixes that. Relates elastic#50938
When you declare an ObjectParser with top level named objects like we do with `significant_terms` we didn't support "did you mean". This fixes that. Relates elastic#50938
When you declare an ObjectParser with top level named objects like we do
with
significant_termswe didn't support "did you mean". This fixesthat.
Relates #50938