-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows newline issue in test #51030
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows Resolves: elastic#50964
tvernum
added
>test
Issues or PRs that are addressing/adding tests
:Security/TLS
SSL/TLS, Certificates
v8.0.0
v7.6.0
labels
Jan 15, 2020
Pinging @elastic/es-security (:Security/Network) |
jkakavas
approved these changes
Jan 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows Resolves: elastic#50964 Backport of: elastic#51030
tvernum
added a commit
to tvernum/elasticsearch
that referenced
this pull request
Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows Resolves: elastic#50964 Backport of: elastic#51030
tvernum
added a commit
that referenced
this pull request
Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows Backport of: #51030
tvernum
added a commit
that referenced
this pull request
Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows Backport of: #51030
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows Resolves: elastic#50964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Security/TLS
SSL/TLS, Certificates
>test
Issues or PRs that are addressing/adding tests
v7.6.0
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows
Resolves: #50964