Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows newline issue in test #51030

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

tvernum
Copy link
Contributor

@tvernum tvernum commented Jan 15, 2020

Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: #50964

Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
@tvernum tvernum added >test Issues or PRs that are addressing/adding tests :Security/TLS SSL/TLS, Certificates v8.0.0 v7.6.0 labels Jan 15, 2020
@tvernum tvernum requested a review from jkakavas January 15, 2020 10:45
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security (:Security/Network)

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polyfractal polyfractal added v7.7.0 and removed v7.6.0 labels Jan 15, 2020
@tvernum tvernum added the v7.6.0 label Jan 15, 2020
@tvernum tvernum merged commit c4c2314 into elastic:master Jan 15, 2020
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
Backport of: elastic#51030
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
Backport of: elastic#51030
tvernum added a commit that referenced this pull request Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Backport of: #51030
tvernum added a commit that referenced this pull request Jan 16, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Backport of: #51030
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Fixes HttpCertificateCommandTests.testTextFileSubstitutions on Windows

Resolves: elastic#50964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Security/TLS SSL/TLS, Certificates >test Issues or PRs that are addressing/adding tests v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpCertificateCommandTests.testTextFileSubstitutions fails on Windows
5 participants