Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an example output of edge n-gram token filter. #51085

Merged
merged 1 commit into from
Jan 16, 2020
Merged

Fix an example output of edge n-gram token filter. #51085

merged 1 commit into from
Jan 16, 2020

Conversation

swen128
Copy link
Contributor

@swen128 swen128 commented Jan 16, 2020

Given a token quick, the default edge n-gram token filter returns [q, qu], not [q, ui].

@cbuescher cbuescher added :Search Relevance/Analysis How text is split into tokens >docs General docs changes v7.5.2 labels Jan 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Analysis)

Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swen128 Thanks for fixing, this is correct. Will merge after running some more tests.

@cbuescher
Copy link
Member

@swen128 can you also please sign the CLA? It is important to use the same email address in CLA as in github / git commit, if you already signed with a different email adress you can add it as a hidden mail address to your github profile. I will run tests in the meantime already.

@cbuescher
Copy link
Member

@elasticmachine test this please

@cbuescher cbuescher merged commit 53909e6 into elastic:7.5 Jan 16, 2020
@cbuescher
Copy link
Member

@swen128 thanks a lot, will merge to 7.5 an newer branches of the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants