Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Expands the documentation of Node Query Cache #51105

Merged
merged 3 commits into from
Jan 20, 2020
Merged

[DOCS] Expands the documentation of Node Query Cache #51105

merged 3 commits into from
Jan 20, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jan 16, 2020 •
edited
Loading

@szabosteve szabosteve added the >docs General docs changes label Jan 16, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

debadair
debadair approved these changes Jan 18, 2020
View reviewed changes
Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one on! Left some minor editorial comments--use if they're helpful.

docs/reference/modules/indices/query_cache.asciidoc Show resolved Hide resolved
docs/reference/modules/indices/query_cache.asciidoc Outdated Show resolved Hide resolved
docs/reference/modules/indices/query_cache.asciidoc Outdated Show resolved Hide resolved
docs/reference/modules/indices/query_cache.asciidoc Show resolved Hide resolved
docs/reference/modules/indices/query_cache.asciidoc Outdated Show resolved Hide resolved
@szabosteve
Copy link
Contributor Author

szabosteve commented Jan 20, 2020 •
edited
Loading

@debadair Thank you for your comments, they are very helpful. I modified the text accordingly.

@szabosteve szabosteve merged commit 451eb1f into elastic:master Jan 20, 2020
@szabosteve szabosteve deleted the node.qc branch January 20, 2020 10:12
szabosteve added a commit that referenced this pull request Jan 20, 2020
@szabosteve @debadair
[DOCS] Expands the documentation of Node Query Cache (#51105)
424b4ed 
Co-authored-by: debadair <debadair@elastic.co>
szabosteve added a commit that referenced this pull request Jan 20, 2020
@szabosteve @debadair
[DOCS] Expands the documentation of Node Query Cache (#51105)
09c8bcf 
Co-authored-by: debadair <debadair@elastic.co>
szabosteve added a commit that referenced this pull request Jan 20, 2020
@szabosteve @debadair
[DOCS] Expands the documentation of Node Query Cache (#51105)
48ab639 
Co-authored-by: debadair <debadair@elastic.co>
@szabosteve
Copy link
Contributor Author

Backport commits:
7.x: 424b4ed
7.6: 09c8bcf
7.5: 48ab639

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
@szabosteve @debadair @SivagurunathanV
[DOCS] Expands the documentation of Node Query Cache (elastic#51105)
9cab6e8 
Co-authored-by: debadair <debadair@elastic.co>
@polyfractal polyfractal added v7.6.0 and removed v7.6.1 labels Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadair debadair debadair approved these changes

@n0othing n0othing Awaiting requested review from n0othing

@jrodewig jrodewig Awaiting requested review from jrodewig

@jimczi jimczi Awaiting requested review from jimczi

Assignees
No one assigned
Labels
>docs General docs changes v7.5.2 v7.6.0 v7.7.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expand on Node Query Cache section of docs
5 participants
@szabosteve @elasticmachine @debadair @jakelandis @polyfractal