Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove types from WatcherSearchTemplateRequest #51112

Merged

Conversation

romseygeek
Copy link
Contributor

There is no longer any point in restricting the types for a Watcher search template. The
types parameter was deprecated in 7x, and can be removed from 8x.

Relates to #41059

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Watcher)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 0f7b97a into elastic:master Jan 17, 2020
@romseygeek romseygeek deleted the types-removal/watcher-search-template branch January 17, 2020 08:47
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
There is no longer any point in restricting the types for a Watcher search template. The
types parameter was deprecated in 7x, and can be removed from 8x.

Relates to elastic#41059
@jpountz jpountz mentioned this pull request Mar 11, 2020
66 tasks
@pgomulka pgomulka mentioned this pull request Mar 25, 2020
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants