-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't overwrite target field with SetSecurityUserProcessor #51454
Merged
probakowski
merged 2 commits into
elastic:master
from
probakowski:setsecurityuserprocessor-overwrite
Jan 27, 2020
Merged
Don't overwrite target field with SetSecurityUserProcessor #51454
probakowski
merged 2 commits into
elastic:master
from
probakowski:setsecurityuserprocessor-overwrite
Jan 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fix problem with `SetSecurityUserProcessor` which was overwriting whole target field and not only fields really filled by the processor. Closes elastic#51428
probakowski
added
v7.7.0
v8.0.0
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
labels
Jan 24, 2020
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
danhermann
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending successful CI
martijnvg
approved these changes
Jan 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
probakowski
added a commit
to probakowski/elasticsearch
that referenced
this pull request
Jan 27, 2020
…1454) * Don't overwrite target field with SetSecurityUserProcessor This change fix problem with `SetSecurityUserProcessor` which was overwriting whole target field and not only fields really filled by the processor. Closes elastic#51428 * Unused imports removed
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>bug
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
v7.6.0
v7.7.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fix problem with
SetSecurityUserProcessor
which was overwritingwhole target field and not only fields really filled by the processor.
Closes #51428