Add empty_value parameter to CSV processor #51567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds `empty_value` parameter to the CSV processor. This value is used to fill empty fields. Fields will be skipped if this parameter is ommited. This behavior is the same for both quoted and unquoted fields.
probakowski
added
>enhancement
:Data Management/Ingest Node
|
Pinging @elastic/es-core-features (:Core/Features/Ingest) |
droberts195
approved these changes
Jan 29, 2020
There was a problem hiding this comment.
LGTM
I also tested it in conjunction with #51492 and elastic/kibana#56038 and confirmed that the end-to-end import process now works with CSV files that have quoted empty fields and also those that have unquoted empty fields. 🎉
| @@ -158,7 +218,7 @@ public void testEmptyFields() throws Exception { | |||
| items.keySet().stream().skip(numItems - 1).forEach(key -> assertFalse(ingestDocument.hasField(key))); | |||
| } | |||
|
|
|||
| public void testWrongStings() throws Exception { | |||
| public void testWrongStings() { | |||
There was a problem hiding this comment.
typo: Sting -> String
(But it was there before and you've got a green build so if no other changes are required then no need to trigger a rebuild just for this.)
jbaiera
approved these changes
Jan 31, 2020
|
@elasticmachine update branch |
|
@elasticmachine update branch |
probakowski
added a commit
that referenced
this pull request
Feb 5, 2020
* Add empty_value parameter to CSV processor This change adds `empty_value` parameter to the CSV processor. This value is used to fill empty fields. Fields will be skipped if this parameter is ommited. This behavior is the same for both quoted and unquoted fields. * docs updated * Fix compilation problem Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds
empty_valueparameter to the CSV processor.This value is used to fill empty fields. Fields will be skipped
if this parameter is omitted. This behavior is the same for both
quoted and unquoted fields.