Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testFlushOnInactive #52275

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Fix testFlushOnInactive #52275

merged 3 commits into from
Feb 12, 2020

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 12, 2020

We need to reduce the translog sync interval for indices with translog async setting so that we can have the safe commit in the assertBusy interval. This is needed since #51905, where we use the local checkpoint of the safe commit to calculate the number of uncommitted operations of a translog stats.

Closes #52251
Relates #51905

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 v7.7.0 labels Feb 12, 2020
@dnhatn dnhatn requested a review from ywelsch February 12, 2020 17:21
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Distributed)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn dnhatn merged commit be4562b into elastic:master Feb 12, 2020
@dnhatn dnhatn deleted the fix-flush-inactive branch February 12, 2020 21:17
dnhatn added a commit that referenced this pull request Feb 12, 2020
We need to reduce the translog sync interval for indices with translog
async setting so that we can have the safe commit in the assertBusy
interval. This is needed since #51905, where we use the local checkpoint
of the safe commit to calculate the number of uncommitted operations of
a translog stats.

Closes #52251
Relates #51905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlushIT.testFlushOnInactive failures
4 participants