Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix put index template bug #52306

Closed
wants to merge 1 commit into from
Closed

Fix put index template bug #52306

wants to merge 1 commit into from

Conversation

gaobinlong
Copy link
Contributor

@gaobinlong gaobinlong commented Feb 13, 2020 •
edited
Loading

The changes are:

  1. Fix the bug for the parameter is_write_index in a alias is ignored when putting index template.
  2. Test parsing the parameters of a alias.

@martijnvg
Copy link
Member

@gaobinlong Can you share how you will end up using is_write_index flag in index templates? The reason I ask is, because just adding is_write_index flag to index templates isn't going to automatically setup the alias and index correctly in order to work with rollover (see logstash-plugins/logstash-output-elasticsearch#858).

@martijnvg martijnvg added the :Data Management/Indices APIs APIs to create and manage indices and templates label Feb 13, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/Indices APIs)

@gaobinlong
Copy link
Contributor Author

@martijnvg, sorry, my fault, I will check the usage of is_write_index carefully and close the PR temporarily.

@gaobinlong gaobinlong closed this Feb 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imotov imotov Awaiting requested review from imotov

Assignees
No one assigned
Labels
:Data Management/Indices APIs APIs to create and manage indices and templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaobinlong @martijnvg @elasticmachine