Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testRestoreLocalHistoryFromTranslog #52441

Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Feb 17, 2020

Asserts that no new operations are made into the translog since we re-opened the engine.

Relates #51905
Closes #52410

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. v8.0.0 v7.7.0 labels Feb 17, 2020
@dnhatn dnhatn requested a review from ywelsch February 17, 2020 23:09
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Engine)

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Feb 18, 2020

Thanks Yannick.

@dnhatn dnhatn merged commit 8ec43df into elastic:master Feb 18, 2020
@dnhatn dnhatn deleted the fix-testRestoreLocalHistoryFromTranslog branch February 18, 2020 13:50
sbourke pushed a commit to sbourke/elasticsearch that referenced this pull request Feb 19, 2020
Asserts that no new operations are made into the translog since we re-opened the engine.

Relates elastic#51905
Closes elastic#52410
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Feb 26, 2020
Asserts that no new operations are made into the translog since we re-opened the engine.

Relates elastic#51905
Closes elastic#52410
dnhatn added a commit that referenced this pull request Feb 26, 2020
Asserts that no new operations are made into the translog since we re-opened the engine.

Relates #51905
Closes #52410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Engine Anything around managing Lucene and the Translog in an open shard. >test Issues or PRs that are addressing/adding tests v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] InternalEngineTests.testRestoreLocalHistoryFromTranslog
4 participants