-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix GCS Mock Range Downloads #52804
Fix GCS Mock Range Downloads #52804
Conversation
We were not correctly respecting the download range which lead to the GCS SDK client closing the connection at times. Closes elastic#51446
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
@tlrx I'm not 100% positive this fixes the issue that caused the last #51446 failures but it's the only thing I could find going wrong at the moment that causes connection drops. |
Bam random find :) => This might actually be the culprit in the linked issue e6565ee :) I'd still like to fix the other issue in here as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for persevering on this Armin!
Np + thanks for reviewing Tanguy! |
We were not correctly respecting the download range which lead to the GCS SDK client closing the connection at times. Also, fixes another instance of failing to drain the request fully before sending the response headers. Closes elastic#51446
We were not correctly respecting the download range which lead to the GCS SDK client closing the connection at times. Also, fixes another instance of failing to drain the request fully before sending the response headers. Closes elastic#51446
We were not correctly respecting the download range which lead
to the GCS SDK client closing the connection at times.
Closes #51446