Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] fixing datafeed bwc tests #52908

Merged
merged 3 commits into from
Feb 28, 2020
Merged

[ML] fixing datafeed bwc tests #52908

merged 3 commits into from
Feb 28, 2020

Conversation

benwtrent
Copy link
Member

Re-enables bwc tests and fixes up code after backport of #52793

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 labels Feb 27, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Member Author

run elasticsearch-ci/bwc

dimitris-athanasiou
dimitris-athanasiou approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 1d4a9bb into elastic:master Feb 28, 2020
@benwtrent benwtrent deleted the feature/ml-datafeed-bwc-tests branch February 28, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
:ml Machine learning >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benwtrent @elasticmachine @dimitris-athanasiou @jakelandis