Remove some deprecation warnings parsing aggs #53026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With elastic#50871 aggrgations should now be parsed directly by an `ObjectParser` or `ConstructingObjectParser` without the need for the ceremonial `parse` method. This removes 10 of those `parse` methods and parses the aggregation directly from their `ObjectParser`.
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
|
@elasticmachine run elasticsearch-ci/1 (Unrelated failure tracked by #52490) |
not-napoleon
approved these changes
Mar 3, 2020
There was a problem hiding this comment.
LGTM. I love a net negative lines PR. Also, I think this resolves #49801 which I see I did a terrible job of naming.
Nice! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 3, 2020
) With elastic#50871 aggrgations should now be parsed directly by an `ObjectParser` or `ConstructingObjectParser` without the need for the ceremonial `parse` method. This removes 10 of those `parse` methods and parses the aggregation directly from their `ObjectParser`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #50871 aggrgations should now be parsed directly by an
ObjectParserorConstructingObjectParserwithout the need for theceremonial
parsemethod. This removes 10 of thoseparsemethods andparses the aggregation directly from their
ObjectParser.Closes #49801.