Move AStatement mutable members into isolated Input/Output objects #53348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (:Core/Infra/Scripting) |
|
@elasticmachine run elasticsearch-ci/2 |
stu-elastic
reviewed
Mar 10, 2020
| * infinite loops during runtime. | ||
| */ | ||
| int statementCount = 0; | ||
| // TODO: remove placeholders once analysis and write are combined into build |
There was a problem hiding this comment.
Can you ref issues in TODO's like this? eg TODO: ..., see #12345.
stu-elastic
reviewed
Mar 10, 2020
| void analyze(ScriptRoot scriptRoot, Scope scope) { | ||
| Output analyze(ScriptRoot scriptRoot, Scope scope, Input input) { | ||
| this.input = input; | ||
| output = new Output(); |
There was a problem hiding this comment.
Consider creating output close to it's first use, at line 68.
stu-elastic
reviewed
Mar 10, 2020
| void analyze(ScriptRoot scriptRoot, Scope scope) { | ||
| Output analyze(ScriptRoot scriptRoot, Scope scope, Input input) { | ||
| this.input = input; | ||
| output = new Output(); |
There was a problem hiding this comment.
Same as above, consider changing where this creation occurs. It's about ~50 lines away from actual use.
|
@stu-elastic Thanks for the review! Will address your comments soon. |
rjernst
approved these changes
Mar 13, 2020
|
@rjernst Thanks for the review. Will commit as soon as CI completes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the follow up to #53075, isolating the mutable data on the statement nodes as the referenced change did the expression nodes.
This is a step toward the long-term goal of making the "user" trees nodes immutable. This change isolates the mutable data for statement nodes in the "user" tree during the semantic (analysis) phase by moving the mutable data into Input and Output objects. These objects are created locally during the semantic phase to share information required for semantic checking between parent-child nodes.
Note that for this change, Input and Output are still stored in a mutable way on the statement nodes. This will not be the case once the semantic (analysis) phase and ir generation (write) phase are combined in a future change.
Relates #49869