Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use Azure Bulk Deletes in Azure Repository (#53919)" #54089

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

original-brownbear
Copy link
Member

This reverts commit 23cccf0.
Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet.

Closes #54080

This reverts commit 23cccf0.
Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet.

Closes elastic#54080
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore)

@original-brownbear
Copy link
Member Author

@tlrx see #54080 (comment) :( SAS token auth is still broken (tried adding logic to generate service level SAS in the code but those are broken as well so no point in that for now).
I don't think there's much use in using bulk deletes with account + key credentials and this path with SAS tokens as most use cases at scale will use SAS token auth anyway so I'm reverting bulk deletes fully for now.

Gnarf

@original-brownbear
Copy link
Member Author

Thanks Tanguy, we'll get this to work one day :)

@original-brownbear original-brownbear merged commit c94be58 into elastic:master Mar 24, 2020
@original-brownbear original-brownbear deleted the 54080 branch March 24, 2020 16:32
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 24, 2020
…lastic#54089)

This reverts commit 23cccf0.
Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet.

Closes elastic#54080
original-brownbear added a commit that referenced this pull request Mar 25, 2020
…#54111)

This reverts commit 23cccf0.
Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet.

Closes #54080
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Mar 26, 2020
…lastic#54089)

This reverts commit 23cccf0.
Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet.

Closes elastic#54080
original-brownbear added a commit that referenced this pull request Mar 26, 2020
…#54248)

This reverts commit 23cccf0.
Unfortunately SAS token auth still doesn't work with bulk deletes so we can't use them yet.

Closes #54080
@original-brownbear original-brownbear restored the 54080 branch August 6, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] AzureStorageCleanupThirdPartyTests AzureStorageRepositoryClientYamlTestSuiteIT
4 participants