Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [ML] explicitly disallow partial results in datafeed extractors (#55537) #55585

Merged
merged 1 commit into from
Apr 22, 2020
Merged

[7.x] [ML] explicitly disallow partial results in datafeed extractors (#55537) #55585

merged 1 commit into from
Apr 22, 2020

Conversation

benwtrent
Copy link
Member

Backports the following commits to 7.x:

@benwtrent
[ML] explicitly disallow partial results in datafeed extractors (elas…
d3e2051 
…tic#55537)

Instead of doing our own checks against REST status, shard counts, and shard failures, this commit changes all our extractor search requests to set `.setAllowPartialSearchResults(false)`.

- Scrolls are automatically cleared when a search failure occurs with `.setAllowPartialSearchResults(false)` set.
- Code error handling is simplified

closes elastic#40793
@benwtrent benwtrent added :ml Machine learning backport labels Apr 22, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent benwtrent merged commit 7c81cd7 into elastic:7.x Apr 22, 2020
@benwtrent benwtrent deleted the backport/7.x/pr-55537 branch April 22, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport :ml Machine learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benwtrent @elasticmachine