-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove synthetic role names of API keys as they confuse users #56005
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…c#56005) Synthetic role names of API keys add confusion to users. This happens to API responses as well as audit logs. The PR removes them for clarity.
…c#56005) Synthetic role names of API keys add confusion to users. This happens to API responses as well as audit logs. The PR removes them for clarity.
#56012) Synthetic role names of API keys add confusion to users. This happens to API responses as well as audit logs. The PR removes them for clarity.
#56011) Synthetic role names of API keys add confusion to users. This happens to API responses as well as audit logs. The PR removes them for clarity.
Removing synthetic roles names from API keys broke the case when an API Key is used to generate a report with Kibana. Kibana requires the user to be a member of one of the roles listed in xpack.reporting.roles.allow. Since the API Key has an empty list of roles, it will always fail that check with no possible work around. |
@ahmbolu Thanks for reporting the issue. I am sorry that the change breaks your workflow. However, role names of API keys are more misleading than they are worth. Because it is possible for two API keys to have the exact same role name but underlyingly each has a completely different set of privileges. That is, For your specific use case, I think the issue is with Kibana in that it relies on role names instead of actual privileges to grant access. Even though the |
This is a Kibana reporting issue that is tracked here: elastic/kibana#76210 |
Thanks Tim. I wasn't aware it is a known issue. |
The synthetic role names of API key add confusion to users. This happens to API responses as well as audit logs. This PR removes them for clarity.