Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] adds geotile_grid support in group_by #56514

Merged

Conversation

benwtrent
Copy link
Member

This adds support for grouping by geo points. This uses the agg geotile_grid.

I am opting to store the tile results of group_by as a geo_shape so that users can query the results. Additionally, the shapes could be visualized and filtered in the kibana maps app.

relates to #56121

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great addition, only added a few nits.

@benwtrent benwtrent merged commit 1c3e450 into elastic:master May 11, 2020
@benwtrent benwtrent deleted the feature/transform-add-geotile_grid-group-by branch May 11, 2020 20:09
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request May 11, 2020
This adds support for grouping by geo points. This uses the agg [geotile_grid](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geotilegrid-aggregation.html).

I am opting to store the tile results of group_by as a `geo_shape` so that users can query the results. Additionally, the shapes could be visualized and filtered in the kibana maps app.

relates to elastic#56121
benwtrent added a commit that referenced this pull request May 11, 2020
This adds support for grouping by geo points. This uses the agg [geotile_grid](https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-bucket-geotilegrid-aggregation.html).

I am opting to store the tile results of group_by as a `geo_shape` so that users can query the results. Additionally, the shapes could be visualized and filtered in the kibana maps app.

relates to #56121
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Aug 4, 2020
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Aug 5, 2020
github-actions bot pushed a commit to elastic/elasticsearch-net that referenced this pull request Aug 5, 2020
github-actions bot pushed a commit to elastic/elasticsearch-net that referenced this pull request Aug 5, 2020
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Aug 5, 2020
Relates: elastic/elasticsearch#56514

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Aug 5, 2020
Relates: elastic/elasticsearch#56514

Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants