Add max_token_length setting to the CharGroupTokenizer #56860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search (:Search/Analysis) |
cbuescher
approved these changes
May 19, 2020
...alysis-common/src/main/java/org/elasticsearch/analysis/common/CharGroupTokenizerFactory.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine test this please |
cbuescher
reviewed
May 19, 2020
...s-common/src/test/java/org/elasticsearch/analysis/common/CharGroupTokenizerFactoryTests.java
Outdated
Show resolved
Hide resolved
|
Thanks for reviewing this @cbuescher |
|
@elasticmachine test this please |
|
@ADBalici I took the liberty to change another checkstyle issue that appeared when running the test, hope you don't mind |
|
@elasticmachine update branch |
|
@elasticmachine test this please |
cbuescher
pushed a commit
that referenced
this pull request
May 20, 2020
Adds `max_token_length` option to the CharGroupTokenizer. Updates documentation as well to reflect the changes. Closes #56676
|
@ADBalici test are all good now, I merged to master and the upcoming 7.9 branch. Thanks for your contribution! |
29 tasks
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Jul 31, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
Relates: elastic/elasticsearch#56860 Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Aug 4, 2020
Relates: elastic/elasticsearch#56860 Co-authored-by: Russ Cam <russ.cam@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
max_token_lengthoption to theCharGroupTokenizer.Updates documentation as well to reflect the changes.
Solves #56676