Introduce Annotation.event field #57144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
changed the title
przemekwitek
force-pushed
the
annotation_subtype_field
branch
from
09c97f8
to
016dcac
Compare
przemekwitek
changed the title
|
Pinging @elastic/ml-core (:ml) |
droberts195
reviewed
May 28, 2020
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/annotations/Annotation.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/annotations/Annotation.java
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/annotations/Annotation.java
Show resolved
Hide resolved
This was referenced May 28, 2020
przemekwitek
force-pushed
the
annotation_subtype_field
branch
from
80d86cb
to
fd488e1
Compare
przemekwitek
force-pushed
the
annotation_subtype_field
branch
from
fd488e1
to
b0e372e
Compare
droberts195
approved these changes
Jun 1, 2020
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/annotations/Annotation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
Annotation.eventfield to distinguish annotations created for different purposes.Currently the two existing events are
delayed_dataandmodel_snapshot_stored.This field is not required. Older annotations will have
nullvalue for it.Additionally, this PR:
Annotation.typefield of type enum. Wire format stays "string" in order to achieve BWC.Annotationparser strictAnnotation::fromXContentso that external code can use that instead ofAnnotation.Builderparser objectRelates #55781