Introduce DataFrameAnalyticsConfig update API #58302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
update_api_for_dfa
branch
11 times, most recently
from
50b649e
to
24c1b35
Compare
przemekwitek
changed the title
|
Pinging @elastic/ml-core (:ml) |
przemekwitek
force-pushed
the
update_api_for_dfa
branch
from
24c1b35
to
59b3221
Compare
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/messages/Messages.java
Outdated
Show resolved
Hide resolved
...test/java/org/elasticsearch/xpack/core/ml/dataframe/DataFrameAnalyticsConfigUpdateTests.java
Outdated
Show resolved
Hide resolved
.../java/org/elasticsearch/xpack/ml/dataframe/persistence/DataFrameAnalyticsConfigProvider.java
Show resolved
Hide resolved
.../java/org/elasticsearch/xpack/ml/dataframe/persistence/DataFrameAnalyticsConfigProvider.java
Outdated
Show resolved
Hide resolved
.../java/org/elasticsearch/xpack/ml/dataframe/persistence/DataFrameAnalyticsConfigProvider.java
Show resolved
Hide resolved
przemekwitek
force-pushed
the
update_api_for_dfa
branch
from
59b3221
to
2f20af1
Compare
dimitris-athanasiou
approved these changes
Jun 26, 2020
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/messages/Messages.java
Show resolved
Hide resolved
Please see my inline comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the Update API for data frame analytics.
Initially, 3 fields are made updatable:
description,model_memory_limitandallow_lazy_start.model_memory_limitcan only be updated when analytics is stopped.descriptionandallow_lazy_startcan always be updated.Relates #45720