Fix privilege requirement for CCS with Point In Time reader #62261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>non-issue
:Security/Authorization
|
Pinging @elastic/es-security (:Security/Authorization) |
| public void testUserWithNoRolesOpenPointInTimeWithRemoteIndices() { | ||
| final boolean hasLocalIndices = randomBoolean(); | ||
| final String[] indices = new String[]{ | ||
| hasLocalIndices ? randomAlphaOfLength(5) : "other_cluster:" + randomAlphaOfLength(5), |
There was a problem hiding this comment.
I would also exercise the condition that remote indices are wildcards (it could be a random)
| @@ -479,6 +484,46 @@ public void testRemoteIndicesOnlyWorkWithApplicableRequestTypes() throws IOExcep | |||
| verifyNoMoreInteractions(auditTrail); | |||
| } | |||
|
|
|||
| public void testUserWithNoRolesOpenPointInTimeWithRemoteIndices() { | |||
| final boolean hasLocalIndices = randomBoolean(); | |||
There was a problem hiding this comment.
set this to both values in a for-each.
...security/src/test/java/org/elasticsearch/xpack/security/authz/AuthorizationServiceTests.java
Outdated
Show resolved
Hide resolved
...ter-search-security/src/test/resources/rest-api-spec/test/multi_cluster/80_point_in_time.yml
Outdated
Show resolved
Hide resolved
albertzaharovits
approved these changes
Sep 14, 2020
|
@ywangd Thanks for fixing this. |
Co-authored-by: Albert Zaharovits <albert.zaharovits@gmail.com>
…into pit-ccs-permission
|
Thanks @albertzaharovits That was a good catch on the yaml test. You are right, neither subsequent search nor close remote PIT require any local privilege. It was a copy/paste error from the previous test's Authorization headers. I have now rectified them. Thanks! |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Sep 21, 2020
…62261) When target indices are remote only, CCS does not require user to have privileges on the local cluster. This PR ensure Point-In-Time reader follows the same pattern. Relates: elastic#61827
ywangd
added a commit
that referenced
this pull request
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When target indices are remote only, CCS does not require user to have privileges on the local cluster. This PR ensure Point-In-Time reader follows the same pattern.
Relates: #61827
@dnhatn @jimczi