-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Use registry for transform templates #63024
Conversation
assertThat(audit.settings().size(), equalTo(3)); | ||
} | ||
|
||
public void testRefactoredMappingsAreSameAsOld() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is key because it proves the mappings have not been altered by the refactoring. The above test asserts none of the other settings have changed.
The mappings defined in TransformInternalIndex
are used in this test and no longer required once I've proved the mappings have not changed. Once the build is green and the PR approved I'd like to remove the static mapping definitions in TransformInternalIndex
and this test.
Pinging @elastic/ml-core (:ml/Transform) |
The build failure is from @hendrikmuhs I cannot see how this change would break that test, could you take a look please
|
The test failure is fixed by #63162 |
49423b2
to
d6257a9
Compare
1fb63a3
to
0fd21f5
Compare
0fd21f5
to
b6a1eb2
Compare
Tests have shown that the use of the template registry rather than the We could add logic to wait for the templates to be installed but the extra complications and hard to maintain code are not worth the small simplification using the registry would enable. Closing without merging |
Change the way transform templates are installed to use a
IndexTemplateRegistry
with mappings stored in resource files.This is the typical way of doing things for many plugins and is the same approach used by ml. This change will enable some common code changes to the auditor in transforms and ml.