-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Groovy as the default scripting language #6571
Switch to Groovy as the default scripting language #6571
Conversation
Fixed the typos, thanks @pickypg |
The table of plugins is better suited for http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/modules-plugins.html#scripting I think, rather than adding a table into this section of the documentation. |
Comma-separated list of methods that are never allowed to be invoked, | ||
regardless of target object. | ||
|
||
`script.groovy.sandbox.enabled`:: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably one of the most important sandbox options, so consider moving this to the top of the group. I'd also consider making this listing a table with name, description and default value(s).
Ugh, did I comment on the commits rather than the diffs? Sorry about that. LGTM though. |
IMO we should to this for other than that LGTM |
@s1monw sounds good, I will merge to master now and backport to 1.4 once we've created a branch for it. |
This is a breaking change to move from MVEL -> Groovy
is the removal of mvel, and recommending using the mvel plugin for backward comp. (and setting the default lang for mvel), going to be in a different change? |
@kimchy yes, I will submit a separate PR for that after this one has been merged. |
Considered a followup to #6233.