Scripting: Whitelist API spec gradle task #66050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu-elastic
added
the
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@elasticmachine run elasticsearch-ci/packaging-sample-unix |
stu-elastic
commented
Dec 8, 2020
| return compare; | ||
| }); | ||
|
|
||
| // TODO(stu): unmodifiable list |
There was a problem hiding this comment.
TODO remove TODO
jdconrad
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
LGTM. Thank you for taking this on!
A couple of thoughts:
- We may want to look at some refactoring as you mentioned in our PR walkthough since this code is used in multiple places.
- Now that there's multiple files I would consider adding a package for whitelist info generation.
stu-elastic
added a commit
to stu-elastic/elasticsearch
that referenced
this pull request
Dec 9, 2020
Adds `generateContextApiSpec` gradle task that generates whitelist api specs under `modules/lang-painless/src/main/generated/whitelist-json`. The common classes are in `painless-common.json`, the specialized classes per context are in `painless-$context.json`. eg. `painless-aggs.json` has the specialization for the aggs contexts Refs: elastic#49879
stu-elastic
added a commit
that referenced
this pull request
Dec 9, 2020
Adds `generateContextApiSpec` gradle task that generates whitelist api specs under `modules/lang-painless/src/main/generated/whitelist-json`. The common classes are in `painless-common.json`, the specialized classes per context are in `painless-$context.json`. eg. `painless-aggs.json` has the specialization for the aggs contexts Refs: #49879 Backport: 2aa2224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
generateContextApiSpecgradle task that generates whitelist apispecs under
modules/lang-painless/src/main/generated/whitelist-json.The common classes are in
painless-common.json, the specialized classesper context are in
painless-$context.json.eg.
painless-aggs.jsonhas the specialization for the aggs contexts