-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "read ingest pipeline" cluster privilege #66137
Adding "read ingest pipeline" cluster privilege #66137
Conversation
The new privilege will allow to run ingest tools with minimal privilege to check whether a pipeline exists, without being able to modify it. This privilege also support simulate pipeline too since it is a readonly operation. Resolve elastic#48028
@elasticmachine update branch |
Fixing tests. Resolve elastic#48028
Fixing tests. Resolve elastic#48028
Fixing tests. Resolve elastic#48028
@elasticmachine update branch |
server/src/main/java/org/elasticsearch/action/ingest/GetPipelineAction.java
Outdated
Show resolved
Hide resolved
@BigPandaToo the unit test class that I alluded to in our conv is |
Resolving bwc, renaming the action Resolve elastic#48028
Fixing doc Resolve elastic#48028
@elasticmachine update branch |
Looking good @BigPandaToo , what it still needs is a simple unit test in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Pinging @elastic/es-security (Team:Security) |
* Adding "read ingest pipeline" cluster privilege The new privilege will allow to run ingest tools with minimal privilege to check whether a pipeline exists, without being able to modify it. This privilege also support simulate pipeline too since it is a readonly operation. Resolve elastic#48028 * Adding "read ingest pipeline" cluster privilege Fixing tests. Resolve elastic#48028 * Adding "read ingest pipeline" cluster privilege Fixing tests. Resolve elastic#48028 * Adding "read ingest pipeline" cluster privilege Fixing tests. Resolve elastic#48028 * Adding "read ingest pipeline" cluster privilege Resolving bwc, renaming the action Resolve elastic#48028 * Adding "read ingest pipeline" cluster privilege Fixing doc Resolve elastic#48028 * Adding "read ingest pipeline" cluster privilege Fixing test * Adding ingest pipeline privileges test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Fixing resolution
* Adding "read ingest pipeline" cluster privilege (#66137) * Adding "read ingest pipeline" cluster privilege The new privilege will allow to run ingest tools with minimal privilege to check whether a pipeline exists, without being able to modify it. This privilege also support simulate pipeline too since it is a readonly operation. Resolve #48028 * Adding "read ingest pipeline" cluster privilege Fixing tests. Resolve #48028 * Adding "read ingest pipeline" cluster privilege Fixing tests. Resolve #48028 * Adding "read ingest pipeline" cluster privilege Fixing tests. Resolve #48028 * Adding "read ingest pipeline" cluster privilege Resolving bwc, renaming the action Resolve #48028 * Adding "read ingest pipeline" cluster privilege Fixing doc Resolve #48028 * Adding "read ingest pipeline" cluster privilege Fixing test * Adding ingest pipeline privileges test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Adding "read ingest pipeline" cluster privilege (#66137) Fixing resolution Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@BigPandaToo @albertzaharovits We have two issues (#56353, #55640) suggesting deprecating the |
I agree with @ywangd - if we've agreed (and I think we have) that |
I plan to open a Refuctoring issue to depricate and change the action names for the following privileges form "admin" to "monitor" : How about I do this privileges name change as part of this refuctoring? |
I think we should just handle this change by itself. We can do a quick rename before 7.11.0 is released so that it doesn't break anything. |
The new privilege will allow to run ingest tools with minimal
privilege to check whether a
pipeline exists, without being able to modify it.
This privilege also support simulate pipeline too since it is a readonly
operation.
Resolve #48028